search

Earthcomputer / multiconnect

A mod to connect to multiple Minecraft server versions
Other
463 stars 52 forks source link

Fix crash when opening creative inventory in singleplayer #523

Closed semjon00 closed 1 year ago

semjon00 commented 1 year ago

Closes #497 Closes #501 Closes #505 Closes #509 Closes #522

There may be a better solution, but IMHO this does just fine.

@Earthcomputer if you merge this, please create a new beta release; this issue is very annoying

semjon00 commented 1 year ago

I tried to understand how fix the root issue, but I couldn't 😞 Maybe inject in ViaMulticonnectTranslator should be changed somehow?

Earthcomputer commented 1 year ago

Turns out that value is intended to be null on singleplayer.

Earthcomputer commented 1 year ago

Merged with changes via https://github.com/Earthcomputer/multiconnect/commit/8d95432becf55ade8482308f302ed42474983dc6

semjon00 commented 1 year ago

Thank you 👍