do not rely on strptime to detect invalid doy (day of year)

EarthyScience / REddyProc

Processing data from micrometeorological Eddy-Covariance systems

58 stars 33 forks source link

do not rely on strptime to detect invalid doy (day of year) #38

Closed bgctw closed 4 years ago

bgctw commented 4 years ago

Currently fConvertTimeToPosix relies on strptime to return NA for implausible doy (day-of-year). This causes a warning or worse on some architectures.

We should explicitly check for leapyears and compare each doy exceeding 365 or 366 respectively before calling strptime.

bgctw commented 4 years ago

fixed by commit 62fe8cb9cf814fd66037465c3d43fe2682eff3f3