Earu / EasyChat

A modular Garry's Mod chat addon for both users and developers. (EOL 2025)
https://steamcommunity.com/sharedfiles/filedetails/?id=1182471500
GNU General Public License v3.0
90 stars 30 forks source link

Images embed from untrustworthy websites #123

Closed unknao closed 2 weeks ago

unknao commented 1 month ago

Title

Cynosphere commented 1 month ago

Oh No! Anyway

PAC3 has the same issue and no one is complaining there. I don't understand the paranoia of having content loaded from """""""""untrustworthy""""""""" websites.

If you want to be a schizo about it, setup an aggressive firewall on your own accord.

unknao commented 1 month ago

It shouldn't be my responsibility to comb through every addon to see if its secure or not, also pac3 not having a website whitelist is an issue as well.

Cynosphere commented 1 month ago

It shouldn't be my responsibility to comb through every addon to see if its secure or not

It should be because URL whitelists are an antipattern and proxying is expensive, whether it be hosting or bandwidth, especially for hobby projects for a sandbox game.

There's not really a risk other than "oh no someone has my IP" which means jack shit modern day.

unknao commented 1 month ago

If Starfall can have a website whitelist, so can easychat. Also comparing anything to pac3 as if it's an example to be followed... lol

Cynosphere commented 1 month ago

If Starfall can have a website whitelist, so can easychat.

Yeah cause we really need a bloated URL list of 200+ vanity domains from trusted image hosts to accommodate for everyone's needs because most of them are stubborn and won't switch off of their image host just to obey a stupid whitelist.

Plus you're complaining on an addon that's going to be archived at the end of the year that only a small minority of servers even use as is because everyone just uses Custom Chat, which has a URL whitelist anyways.

Maybe it's just time you find a better server then if you're paranoid about the players on it IP logging you or what not. ¯\_(ツ)_/¯

unknao commented 1 month ago

I'm sure that if you argue in circles some more and say nothing of value that will validate your position on allowing ip grabbing that you are opted in to by default.

jule14 commented 1 month ago

I'm sure that if you argue in circles some more and say nothing of value that will validate your position on allowing ip grabbing that you are opted in to by default.

i know that you have the extravagant urge to annoy children on gmod servers but if it leads to being a target of them ie. this issue then maybe it's best not to 😄

Earu commented 1 month ago

On a more serious note, I've been aware of this for the longest time but there's no reasonable solution for this. Let me explain why:

So ultimately what would probably work is letting the user decide what is trustworthy or not, but I feel like this is more of a client issue than a EasyChat issue.

Earu commented 2 weeks ago

Closing as issue is stale and no fix / proper solution in sight.