Earu / EasyChat

A modular Garry's Mod chat addon for both users and developers. (EOL 2025)
https://steamcommunity.com/sharedfiles/filedetails/?id=1182471500
GNU General Public License v3.0
90 stars 31 forks source link

Ignore Module file incorrectly exploding #71

Closed KyleNaCl closed 3 years ago

KyleNaCl commented 3 years ago

when you load module_ignore_list.txt the contents do not get exploded properly and shows as 1 item in the table

1   =   easychat/modules/client/voice_hud.lua
easychat/modules/indications.lua
easychat/modules/join_leave.lua

i believe this is due to the extra parameters passed into local lines = ("\r?\n"):Explode(file_contents) switching to local lines = ("\n"):Explode(file_contents) fixes the current problem of wanting to ignore multiple modules

how the contents in my module_ignore_list.txt are listed

easychat/modules/client/voice_hud.lua
easychat/modules/indications.lua
easychat/modules/join_leave.lua

I also have noticed when you have multiple modules ignored, the list in the easychat settings menu doesn't list them all, more than likely due to the same issue of not exploding the file properly Screenshot_1034

Earu commented 3 years ago

Thank you for that report, I’ll see what I can do

Sent from my iPhone

On 25 Jul 2021, at 20:34, Kyle @.***> wrote:

 when you load module_ignore_list.txt the contents do not get exploded properly and shows as 1 item in the table

1 = easychat/modules/client/voice_hud.lua easychat/modules/indications.lua easychat/modules/join_leave.lua i believe this is due to the extra parameters passed into local lines = ("\r?\n"):Explode(file_contents) switching to local lines = ("\n"):Explode(file_contents) fixes the current problem of wanting to ignore multiple modules

how the contents in my module_ignore_list.txt are listed

easychat/modules/client/voice_hud.lua easychat/modules/indications.lua easychat/modules/join_leave.lua I also have noticed when you have multiple modules ignored, the list in the easychat settings menu doesn't list them all, more than likely due to the same issue of not exploding the file properly

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Earu commented 3 years ago

https://github.com/Earu/EasyChat/commit/946e36ad8b412d235138afc9a8b1ee1b1edc49fe