Earu / EasyChat

A modular Garry's Mod chat addon for both users and developers. (EOL 2025)
https://steamcommunity.com/sharedfiles/filedetails/?id=1182471500
GNU General Public License v3.0
90 stars 31 forks source link

RichNick returns SteamName and not player Nick which breaks DarkRP compatibility #91

Closed Norway174 closed 2 years ago

Norway174 commented 2 years ago

In this commit https://github.com/Earu/EasyChat/commit/e80bf9f3c6b6e4f7e9c4e48d4bc478ba62df620a all :Nick calls were changed to :RichNick.

DarkRP changes the players names in Nick, and by not using Nick, the chat will use players Steam names, and not their RP names.

image For the purpose of this image, I set my RP name to "Test" with DarkRP.

But my name doesn't show up as Test in the Chat box when I speak.

Earu commented 2 years ago

Hi thank you for reporting that issue, I wasn't sure it was from the DarkRP game mode. I'm not actually sure how to handle this properly, there is a conflict of overwrites here. However I'll definitely be looking into it.

Earu commented 2 years ago

Fixed in https://github.com/Earu/EasyChat/commit/5209a9213f209b5c0757b16702de9448cbdd4151

Norway174 commented 2 years ago

Hey, Not sure what's causing it this time. But I just updated the EasyChat again from the Workshop.

And it seems the DarkRP chat names are broken again. It's showing the Steam names, instead of the RP names. I'll try and help out some more and look into exactly which update is doing it. But sadly I don't have the time right now.

But I figured I'd re-open this issue again so you're aware of it. Or maybe you even already have an idea what could be causing it? Edit: Seems like I can't re-open the issue. Should I make a new one? Edit2: Ignore this. I'm dumb. The workshop version was just outdated.