Earu / neo-chatsounds

Memes in the Garry's Mod chat.
https://github.com/Earu/neo-chatsounds
GNU Affero General Public License v3.0
10 stars 4 forks source link

Prefer using a commit hash over a branch name #14

Open sr229 opened 1 month ago

sr229 commented 1 month ago

Tracking a cache by commit hash is much more consistent caching-wise and wouldn't require the system to constantly pull data every time a reload is needed since you only need to check for the latest commit every time.

Earu commented 1 month ago

It wouldn't change anything from what's already happening really, just a different hash.

If I wanted to do this I would probably have to do another request during init towards the GitHub API, and let's just say the less requests are done the better.

There are also other considerations, Like what if I wanted to add a source that's not GitHub ?