Closed chowarth closed 4 years ago
Chris, Thanks for working on this PR. I'll take a look through it. Having a wider set of unit test frameworks would be great.
π If there's anything that needs changing (or you're not happy with π) just let me know.
I believe the build is broken because an explicit dotnet restore
step needs adding.
Hi @duanenewman , have you had a chance to look over this at all? Looking to start a fresh project soon and would like to be able to use Ease from the get go with xUnit
.
@chowarth I'm working on it.. also working on getting CLA setup before I accept contributions. I think that is done now, check out the above comment from CLA Assistant.
Lots of changes, so taking a little while to go through. Overall I think I'm happy with the commit, I have some coding preferences I'll work on documenting, but I don't think any of those should block this change.
Since XUnit does a few things different from NUnit or MSTest for test lifecycle it eliminates the need for the container resetting that Ease does, but it still allows the mocking help and Prism Forms conveniences.. and I have done a little looking, we may yet be able to capitalize on not needing to rebuild the container each time (which can get expensive timewise) using a Class Fixture.. will have to dig a little more for a future change.
@chowarth can you pull latest from master and merge in to fix the conflicts? I think that is all, if the build is stopping it then I'll work to get appveyor fixed as well.
@chowarth can you pull latest from master and merge in to fix the conflicts? I think that is all, if the build is stopping it then I'll work to get appveyor fixed as well.
All updated, did mean to do that after the PR changes then forgot π Glad I could be of use, my first real contribution to something and it feels good!
Implements #3
This PR adds support for xUnit.
@duanenewman, the only thing I'm not really sure on is how to update the projects for correctly for NuGet packaging.
Details
Key points of the refactor while adding support for xUnit include:
Xamarin.Forms
as this is not specifically required it's just aPrism.Forms
dependencyEase
ContainerTestBase
Ease.DryIoc
DryIocContainerTestBase
Ease.Unity
UnityContainerTestBase
MSTest
NUnit
DryIoc
Ease.NUnit.DryIoc
Ease.NUnit.DryIoc.PrismForms
Ease.NUnit.DryIoc.PrismForms.Tests
Unity
Ease.NUnit.Unity
Ease.NUnit.Unity.PrismForms
Ease.NUnit.Unity.PrismForms.Tests
XUnit
DryIoc
Ease.XUnit.DryIoc
Ease.XUnit.DryIoc.PrismForms
Ease.XUnit.DryIoc.PrismForms.Tests
Unity
Ease.XUnit.Unity
Ease.XUnit.Unity.PrismForms
Ease.XUnit.Unity.PrismForms.Tests
PrismFormsTestBase
PrismFormsTestBase
helper methodsINavigationService
extensions will now work properlyScopeTest
fixture tests