search

EastAgile / robber.py

BDD / TDD assertion library for Python
MIT License
8 stars 1 forks source link

[f] Contain/exclude multiple args #46

Closed catriuspham closed 7 years ago

catriuspham commented 7 years ago

Related issue

https://github.com/EastAgile/robber.py/issues/11

Description

Now contain/exclude can take multiple args

expect(a).to.contain(x, y, z)
expect(a).to.exclude(x, y, z)
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 44998ea3c3086e80bffeab625e97bc3629c97047 on feature/multiple-contain into 3fb4ab4848d3b0761d7f572873dc08b94ae48d71 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9c86a01fba58faae5de8eec52ada8fbd01d8ee8c on feature/multiple-contain into 3fb4ab4848d3b0761d7f572873dc08b94ae48d71 on master.

catriuspham commented 7 years ago

@hieueastagile This PR is rather old, please take a look and see if we can merge it, thanks :smile:

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d18ae9c3e767e5b98db15731a03aad610aae4510 on feature/multiple-contain into 3fb4ab4848d3b0761d7f572873dc08b94ae48d71 on master.

catriuspham commented 7 years ago

@hieueastagile Did you see the update I made some days ago?

hieueastagile commented 7 years ago

I saw it, but I think do you think that we still can improve the readability here? I know it's annoying and I'm sorry about that but I still see it could be improved more :(.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3c95c85df4a2d2435fe162b6da3df61c0d20827c on feature/multiple-contain into 3fb4ab4848d3b0761d7f572873dc08b94ae48d71 on master.

catriuspham commented 7 years ago

@hieueastagile Best I can do is to create the function _get_first to DRY it a bit. Please check if you think it's better now :smile:

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3afdd387197d693a39e5758f568519198be5bedd on feature/multiple-contain into 8107f3a283943b236f20d5b751d30b3d52de468a on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7cd539b02d2dd84a45eaf5a30e6edf3977aaa259 on feature/multiple-contain into 8107f3a283943b236f20d5b751d30b3d52de468a on master.

hieueastagile commented 7 years ago

LGTM, let's merge this, thanks @catriuspham

catriuspham commented 7 years ago

@oyster Please help merge this and close the following issue: https://github.com/EastAgile/robber.py/issues/11 thanks.

oyster commented 7 years ago

All requested pull requests and relevant issues should be merged and closed now. Please let me know if you need anything else, @catriuspham.