EastAgile / robber.py

BDD / TDD assertion library for Python
MIT License
8 stars 1 forks source link

[f] Better success message #52

Closed catriuspham closed 7 years ago

catriuspham commented 7 years ago

Related issue

https://github.com/EastAgile/robber.py/issues/43

Description

Print "True" in ipython and python shell if an expectation passes.

In: expect(1).to.eq(1)
Out: True
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling c7a571a35df8076f62c7f21dd3400be980181c6e on feature/success-message into 866279bf95c475a7b91bb0a71becd9d3be9ec63b on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling c1b24785b52670f9f22cc2b9cedc53b5f48d3629 on feature/success-message into 866279bf95c475a7b91bb0a71becd9d3be9ec63b on master.

catriuspham commented 7 years ago

@hieueastagile This is just a small change, please consider if we can merge it.

hieueastagile commented 7 years ago

@catriuspham Sorry for not checking this sooner, but please give me a few days, I guess I need to do a careful tests for this (and the other PR which is still on hold).

catriuspham commented 7 years ago

@hieueastagile Okay, take your time.

hieueastagile commented 7 years ago

Looks good so far, please ask anh Quang to merge this, thanks @catriuspham

catriuspham commented 7 years ago

@oyster Please help merge this and close https://github.com/EastAgile/robber.py/issues/43, thanks