search

EastAgile / robber.py

BDD / TDD assertion library for Python
MIT License
8 stars 1 forks source link

[c] Better explanation for ordered dict #58

Closed catriuspham closed 7 years ago

catriuspham commented 7 years ago

Related issue

https://github.com/EastAgile/robber.py/issues/48

Description

Ordered dicts are now handled the same as dicts

Usage

In [1]: d = {'a': '1', 'b': '2', 'c': '3'}
In [2]: od = OrderedDict({'a': '2', 'b': '2', 'c': '3'})
In [3]: expect(d).to.eq(od1)

Out: 
BadExpectation: 
A = {'a': '1', 'b': '2', 'c': '3'}
B = {'a': '2', 'b': '2', 'c': '3'}
Expected A to equal B
A['a'] = 1 while B['a'] = 2
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.816% when pulling cdc2ab80d9e9600466c1d4757645e197728a8aff on chore/better-explanation-for-orderdict into 85ce13ae06cc6f8c908bcd58fd71b928d2249176 on master.

catriuspham commented 7 years ago

@hieueastagile This should have been based on feature/unicode-comparison, sorry if this got you any trouble reviewing the code. Anyway, I gonna make the code in base.py look better.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6881be0792bc3523528d9de429d10b40a4cbe745 on chore/better-explanation-for-orderdict into b5562db341a08568cea031e97a3bc1fbafce2eb8 on feature/unicode-comparison.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6881be0792bc3523528d9de429d10b40a4cbe745 on chore/better-explanation-for-orderdict into b5562db341a08568cea031e97a3bc1fbafce2eb8 on feature/unicode-comparison.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6881be0792bc3523528d9de429d10b40a4cbe745 on chore/better-explanation-for-orderdict into b5562db341a08568cea031e97a3bc1fbafce2eb8 on feature/unicode-comparison.

catriuspham commented 7 years ago

@hieueastagile I made some update to avoid the repetitiveness

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 99.094% when pulling b959afd8ead69a81a0f7d4bb1aadb5ef91a0d7db on chore/better-explanation-for-orderdict into 485cc0cb8532e5ac3271e299bea416dc6c042e9a on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d76fa3877a5baf6448e3718ac51985ca9e01cd6b on chore/better-explanation-for-orderdict into 485cc0cb8532e5ac3271e299bea416dc6c042e9a on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d76fa3877a5baf6448e3718ac51985ca9e01cd6b on chore/better-explanation-for-orderdict into 485cc0cb8532e5ac3271e299bea416dc6c042e9a on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d76fa3877a5baf6448e3718ac51985ca9e01cd6b on chore/better-explanation-for-orderdict into 485cc0cb8532e5ac3271e299bea416dc6c042e9a on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d76fa3877a5baf6448e3718ac51985ca9e01cd6b on chore/better-explanation-for-orderdict into 485cc0cb8532e5ac3271e299bea416dc6c042e9a on master.

catriuspham commented 7 years ago

@oyster Please help merge this PR and close this issue: https://github.com/EastAgile/robber.py/issues/48. Thanks.