EastAgile / robber.py

BDD / TDD assertion library for Python
MIT License
8 stars 1 forks source link

[r] Improve diffs, fix mock matchers won't work properly when there are only kwargs #62

Closed catriuspham closed 7 years ago

catriuspham commented 7 years ago

Related issues

https://github.com/EastAgile/robber.py/issues/60 https://github.com/EastAgile/robber.py/issues/61

Description

The title says it all

Changes

Notes

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f8a06e036511812f56e368eb79cd7f9c7fdda60b on chore/improve-diffs-fix-only-kwargs into ca310252f8c3e03bd75b27d8e2a4957c6127ac60 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f8a06e036511812f56e368eb79cd7f9c7fdda60b on chore/improve-diffs-fix-only-kwargs into ca310252f8c3e03bd75b27d8e2a4957c6127ac60 on master.

catriuspham commented 7 years ago

@hieueastagile I know that you are really busy, but there're too many unmerged PRs... Please take a look at this one also.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 6193743de7775bb7f0dcd7c9f14bbf112393b5f1 on chore/improve-diffs-fix-only-kwargs into ca310252f8c3e03bd75b27d8e2a4957c6127ac60 on master.

catriuspham commented 7 years ago

@nhanbt This will make the called_once_with work :muscle:

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling c6a22895eb2070e948d3e897f93993db2f3b8ac4 on chore/improve-diffs-fix-only-kwargs into 8107f3a283943b236f20d5b751d30b3d52de468a on master.

catriuspham commented 7 years ago

@oyster Please help merge this PR thanks.

catriuspham commented 7 years ago

@oyster and close these following issues: https://github.com/EastAgile/robber.py/issues/60, https://github.com/EastAgile/robber.py/issues/61

hieueastagile commented 7 years ago

If you are the one who opened it, you can close it too @catriuspham :P.

catriuspham commented 7 years ago

@hieueastagile Now I notice that 😮 Thanks for reminding.