Closed steadykhoi closed 5 years ago
@oyster
Not sure why the test coverage drops. Could you please help to check again? Thanks.
@steadykhoi and @anhtran11, any more update on this?
@oyster Sorry I completely forgot about this PR. But we still need this small changes as we continue to use robber in a lot of our projects. Please review again, thanks!
Thanks. Merging now.
Description
Previously when doing
expect(dict_a).to.eq(dict_b)
if the 2 dictionaries has different number of keys it will just display this unhelpful message: "A and B does not have the same length". Now it will tell which key is missing "A has key 'foo' while B does not" or "B has key 'bar' while A does not".Usage
Secondary changes
idna
which we depend on has dropped support for Python 2.6 and judging by how there's no longer a 2.6 tag for Python official image on Docker hub I think there are not many people using Python 2.6 anymore anyhow.