Error message text

[nilesbarnes]

Consider different error text when a route cannot be established. Currently states, "No route could be found between those locations." Could see that be confusing when a route clearly exists the system is just having an error. Better to recommend that the user select a shorter route, i.e. shorter distance between start and end points?

[danrademacher]

That's a good suggestion! Also, part of the editing webinar will be about data changes we'll want your team to make, with their local knowledge, that should eliminate many of these unroutable conditions. Most we have found relate to unmatched N + S routes so you end up with a route that works one way but not the other. It's not always obvious for us from afar whether a path should really be B or if one or more lines need to be switched, or another one-way line added.

[clhenrick]

Not a problem to update the error message text, we would need to change it in the code for the ecg-map-router though.

[danrademacher]

This needs to change: https://github.com/GreenInfo-Network/ecg-map-router/blob/ff51b9bad7ee4f745c52d5a5fb1ea102be2861e8/src/router.js#L98

New text: "Please try a shorter route."

Note: We realize that a shorter route won't ALWAYS fix the issue if such route is on top of a topological error, but it will USUALLY fix the issue, and we don't want to say "no route found" when there's a line on the map connecting the two places.

[gregallensworth]

Error message has been updated.

[danrademacher]

Great, thanks. @clhenrick do you need to do something for Greg's change to go live in the app?

[clhenrick]

Implemented.

Updating this app with changes made to the ecg-map-router just involves copying the code from ecg-map-router/dist to client/lib/ecgClientRouter.js and then redeploying to Heroku.