EastCoastGreenwayAlliance / ecg-map

Interactive map and trip planner for the ECGA
https://map.greenway.org
7 stars 0 forks source link

Fix Mapbox attribution on lower left when MB map enabled #71

Closed danrademacher closed 7 years ago

danrademacher commented 7 years ago

We're properly switching from "© Carto" to "© Mapbox" in the text credit in lower right of the map, but the Carto logo is persisting on lower left:

image

Looks like there's info here on how to pull in their wordmark:

https://www.mapbox.com/help/how-attribution-works/#other-mapping-frameworks

will need to switch back and forth as basemap changes

clhenrick commented 7 years ago

@danrademacher the Carto logo is required to be displayed for their non-profit grants program.

danrademacher commented 7 years ago

Hmm, and when we are using a Mapbox map, they want their logo. We don't want to have two logos showing. I will check with Tyler at Carto to clarify requirements around the logo on the app.

clhenrick commented 7 years ago

The mapbox attribution displays in the lower right when you have the Mapbox basemap enabled, which I think is sufficient.

danrademacher commented 7 years ago

Not according to their documentation:

If you are using Mapbox maps with another open source library, like Leaflet or OpenLayers, the Mapbox wordmark and attribution are still required.

clhenrick commented 7 years ago

Although I'm noticing when the app first loads the Positron tiles display by default and the Mapbox attribution is incorrectly displayed. After a new basemap layer is toggled the attribution is correct.

clhenrick commented 7 years ago

@danrademacher it seems less concerning as they aren't giving us a grant IMO.

danrademacher commented 7 years ago

OK, everyone requires logos (strike down one advantage of not using Google...). Tyler from Carto confirmed that any view using Carto tech (most of them) needs Carto logo, regardless of basemap. Mapbox requires their logo when their basemap in use.

Solution, move scale bar up, Carto logo to far left:

image

And with Mapbox logo (approximate): image

clhenrick commented 7 years ago

Tried to space it as tightly as possible:

localhost-8888--loc 5 36 93233 -74 50928 iphone 6 1