search

Eastrall / EntityFrameworkCore.DataEncryption

A plugin for Microsoft.EntityFrameworkCore to add support of encrypted fields using built-in or custom encryption providers.
MIT License
326 stars 54 forks source link

Skip properties whose propertyInfo value is null #11

Closed ekastimo closed 3 years ago

ekastimo commented 3 years ago

After doing some troubleshooting, I think there is a bug in the extension method, it appears that in the process of reading the properties from entities, some properties which are not discriminators also have PropertyInfo as null, in my case, it was owned, classes. ( They have some sort of ID).

This PR would fix this issue

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@773c722). Click here to learn what that means. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master       #11   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         4           
  Lines             ?        60           
  Branches          ?         0           
==========================================
  Hits              ?        60           
  Misses            ?         0           
  Partials          ?         0
Impacted Files Coverage Δ
...eworkCore.DataEncryption/ModelBuilderExtensions.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 773c722...9fda3d4. Read the comment docs.

Eastrall commented 3 years ago

Thanks for the PR! Looks good to me. Merging... 😄