Eastrall / EntityFrameworkCore.DataEncryption

A plugin for Microsoft.EntityFrameworkCore to add support of encrypted fields using built-in or custom encryption providers.
MIT License
326 stars 54 forks source link

Update the library to support .Net6 and EF Core 6. #33

Closed owaits closed 2 years ago

owaits commented 2 years ago

When updating a project to .Net6 that uses this amazing encryption library it would not run the DB migrations because of a missing method exception for ClrType. I believe this was due to this library targeting the wrong version of EF Core. This PR upgrades the library to EF Core 6.0 and resolves the issue with running migrations on EF Core 6 projects.

It would be great if the nuget package could also get updated.

Eastrall commented 2 years ago

Hello, thank you for openning a PR to help us improve the library! You are actually updating the library to target net6 only. 😢 This will break the support for existing projects that are using the library on .NET Core 3.1. Check out PR #34

I saw you've fixed a little typo on the EncryptionMigrator.cs file. Feel free to open a new PR to include this change in future release. 😄

owaits commented 2 years ago

Yes I did realise this would remove support for older versions of .net. I was not sure how you wanted to handle this. Multi targeting the project is a better solution. I will put up a PR for the typo.

Eastrall commented 2 years ago

Don't bother opening a PR, this has been handled by #34 😉