search

EasyAbp / AbpHelper.CLI

Providing code generation and more features to help you develop applications and modules with the ABP framework.
MIT License
284 stars 94 forks source link

for generate Viewmodels and Cshtml missing directive using reference #75

Closed blyzer closed 4 years ago

blyzer commented 4 years ago

mostly of the change is automatic formatting, I can revert this.

I change all variable declaration for type declaration. I understand more readable.

but with can consider this: The var keyword can also be useful when the specific type of the variable is tedious to type on the keyboard, or is obvious, or does not add to the readability of the code. One example where var is helpful in this manner is with nested generic types such as those used with group operations. In the following query, the type of the query variable is IEnumerable>. As long as you and others who must maintain your code understand this, there is no problem with using implicit typing for convenience and brevity.

var versus concrete type usage and from here too: Implicitly typed local variables (C# Programming Guide)

both we can revert for a separate branch.

blyzer commented 4 years ago

and I add all configuration from Idea or VS to .gitignore file and removed from the repository

wakuflair commented 4 years ago

Hi @blyzer First thank you for your PR. However there are some problems with your PR we cannot accept it:

  1. There are conflicts
  2. Too many changed files (some of them are unnessasery I think) that we cannot verify them easily.
  3. The purpose of this PR is not very clear

So I close this PR for now. Feel free to add comments for further discussion.