search

EasyCorp / EasyAdminBundle

EasyAdmin is a fast, beautiful and modern admin generator for Symfony applications.
MIT License
4.05k stars 1.02k forks source link

Wrong flag CY #5162

Closed whyte624 closed 2 years ago

whyte624 commented 2 years ago

Describe the bug assets/images/flags/CY.png flag is wrong. Real flag is with silhouette of Cyprus island.

Additional context Also showFlag option for CountryField does not work for edit form - Choice list contains flags regardless showFlag custom option.

If possible, fix in 3.5.* version also.

javiereguiluz commented 2 years ago

Yes, this flag is completely wrong 😞 @whyte624 thanks for reporting this!

Instead of fixing this, and given that we've been reported other issues related to flags, I'm thinking about updating the flag library. I always wanted to use SVG flags, but in the past I didn't find any library with minimalist flags and lightweight files (in some library, complex flags like the Andorra country weight more than 30 KB !!). However, I think I've found a library with minimalist and lightweight SVG files: https://github.com/catamphetamine/country-flag-icons/tree/master/flags/3x2

I'm going to experiment with this and see if we can upgrade the flags.