search

EasyCorp / EasyAdminBundle

EasyAdmin is a fast, beautiful and modern admin generator for Symfony applications.
MIT License
3.99k stars 1.01k forks source link

Remove final attribute #5299

Closed xkzl closed 1 year ago

xkzl commented 1 year ago

I haven't seen a bundle with so many final classes.

Can you please remove final attribute of unharmful classes for god's sake ? This prevent many improvements and customizations.

I have to rewrite/copy/paste most of your work and this is IMO again most of coding principle.

For instance, I want to add some SAVE_GOTO_NEXT action across dashboard in a proper way and add builtin actions and this is not possible. So I don't want to put core code into configureAction but pass a class. This is very restrictive.. I have plenty of exemples like this and that would require only to remove final class to get cleaner.

Thank you

javiereguiluz commented 1 year ago

See https://github.com/EasyCorp/easyadmin-no-final-plugin

xkzl commented 1 year ago

Thank you so much @javiereguiluz

jbonnier commented 1 month ago

@javiereguiluz but why a plugin instead of simply letting dev extends some unharmfull classes out of the box?