Less attractive detail page rendering

[john-dufrene-dev]

Hi,

This may be a bug in my application, but I haven't found a way to fix it by removing much of what I created myself.

I find that the rendering of the detail page is less good than what was there before, perhaps my personal opinion,

I wanted to get your opinion, already if it's a bug on my side and if you prefer the new rendering,

This is the old rendering :

This is the new rendering :

Thank you for your feedback,

[mahono]

The layout changed since 4.8.0 to be like the new/edit pages.

It was probably changed so that the new columns layout feature looks nice on the detail page. But I see your point.

I think it would be really useful to preserve the old layout as an alternative and provide a method in the Crud config class to „opt in“ to the new layout in 4.x versions and maybe make the new layout the default from 5.0 on?

But keeping both layouts would really be nice.

[ServerExe]

I was also really confused that suddenly my styles got broken. To me this is actually a breaking change in a minor version. We are using automatic updates in Github for composer packages and this new version just changed the entire layout of detail pages. Especially for empty fields, there are just labels but no values underneath. An "empty" badge would be nice like it is for NULL, at least. Otherwise, it just looks like multiple bold labels are displayed one below the other and you have to figure out "Is this a value of my field now? Or is this the next field's label"?

[alan-emiles]

Happened to me too - i was confused, and now will have to fix composer to the old version until this is resolved.

i like the feature to have multiple columns - but i don't like the new details layout tbh, it makes the page longer and it should be a config option so it doesn't break everyone's layouts.

Thanks!

[john-dufrene-dev]

@javiereguiluz did you see this issue ?

[armellin]

I also would like this to be an opt-in.

Thanks

[javiereguiluz]

I've been playing a bit with this and I'm going to submit soon a proposal to improve this a lot (it will look similar to the previous design, but better).

[javiereguiluz]

Here's a proposal to change this: #5977

Please test it before we merge it. Thanks!

[jordihendrix]

While the tweaks to the design do make it look slightly better, they don't solve the actual problem here: the changes to the HTML/CSS break backward compatibility with any custom HTML/CSS. I understand you may feel backward compatibility doesn't apply to such things, but dealing with such visual changes often puts developers in a lot more difficult of a position than a simple code BC break which can just be fixed. Having to redo a bunch of custom HTML/CSS to suit the new structure (and design) is a lot of work, and that's not even counting the headache of having to deal with all your customers going "why does this suddenly look different?", "change it back!".

So in conclusion: please, please, please don't make changes like this in minor versions, or at least make them opt-in only. I understand EasyAdmin is free open-source software and you do not "owe" us anything, but it would make a lot of developer's lives a lot easier if situations like these could be avoided.