Fix empty query term conditions

EasyCorp / EasyAdminBundle

EasyAdmin is a fast, beautiful and modern admin generator for Symfony applications.

MIT License

3.99k stars 1.01k forks source link

Fix empty query term conditions #6227

Open guillaume-sainthillier opened 2 months ago

guillaume-sainthillier commented 2 months ago

When only numeric fields are searchable, EntityRepository::addSearchClause generates a bugged DQL when search contains only non numeric terms.

Seb33300 commented 1 month ago

@javiereguiluz This PR is the correct fix for https://github.com/EasyCorp/EasyAdminBundle/issues/6223

https://github.com/EasyCorp/EasyAdminBundle/pull/6242 must be reverted (it breaks postgres) and replaced by this PR. See details in https://github.com/EasyCorp/EasyAdminBundle/pull/6262

Seb33300 commented 1 month ago

@guillaume-sainthillier could you commit revert of https://github.com/EasyCorp/EasyAdminBundle/pull/6242 in this PR?

guillaume-sainthillier commented 1 month ago

@guillaume-sainthillier could you commit revert of #6242 in this PR?

done

guillaume-sainthillier commented 1 week ago

Hello @Seb33300, any updates about this PR? Does I need to add something?

Seb33300 commented 1 week ago

Hi @guillaume-sainthillier, I just tried to help by reviewing it but I am not a maintainer of the project. We need to wait for @javiereguiluz to review and merge the PR.