[RFC] Add support for defining the translation_domain of property labels

[javiereguiluz]

In #716 @reypm discussed about this use case: he wants to reuse the translations of FOSUserBundle for the property labels. Should we add this feature or should we consider an edge case and ignore it?

The changes that it would imply:

• We should add a new configuration option for properties because form based views could use type_options: { translation_domain: 'FOSUserBundle' } but list and show views cannot use that trick.
• Form based views should update the form theme to take into account the translation_domain of each property
• list and show views should updated their Twig template code to take into account the translation_domain of each property

[ogizanagi]

Seems legit to me. In a growing app, you might want to use multiple domains anyway. :+1:

[javiereguiluz]

As usual, let's see how does Sonata solve this problem. In this article we can see that you can define the translation domain in two ways:

• Globally for the entire Admin class (equivalent to our Entity config) via the $translationDomain property. Example:

class PageAdmin extends Admin
{
    protected $translationDomain = 'SonataPageBundle'; // default is 'messages'
}

• Locally for each field (equivalent to our entity properties) via the translation_domain option. Example:

->add('publishable', 'checkbox', array(), array(
    'translation_domain' => 'MyTranslationDomain',
))

[ogizanagi]

A per entity translation_domain is good to me too (in complement of per-field of course), but there is one flaw with that: You might want to configure the translation_domain for the entity label (in the left-menu for instance). Should a translation_domain option at the entity level configure both entity label and all properties ?

BTW, those new issues are great, nice work @javiereguiluz :)

[reypm]

@javiereguiluz I know you're very busy but some advice on this?

[nassuf]

Hi everyone, @javiereguiluz Is there any update about this feature ? How can we help ? Thanks

[javiereguiluz]

Closing it as fixed by #1347. This will be available in the next stable version (to be released soon).