search

EasyCorp / easy-deploy-bundle

The easiest way to deploy your Symfony applications
https://easycorp.io/EasyDeploy
MIT License
471 stars 103 forks source link

Allow Symfony 5 components #103

Closed Lustmored closed 4 years ago

Lustmored commented 4 years ago

Also closes #100 - use new Process method to create object from shell command when available

COil commented 4 years ago

Hi @Lustmored , thanks for the PR. The travis build fails:

Problem 1

- symfony/console v5.0.0 requires php ^7.2.5 -> your PHP version (7.1.27) does not satisfy that requirement.

As 7.1 is EOL, I think we should change the version to 7.2. Can you make a try please?

gustawdaniel commented 4 years ago

Can I please accept this pull request?

COil commented 4 years ago

The PR can't be accepted as checks are failing. The PHP version requirements must be changed to ^7.2.5

Lustmored commented 4 years ago

Sorry guys for taking long to answer, didn't receive notifications somehow. I am experimenting with PHP version constraints, not a Travis master but will do my best.

Lustmored commented 4 years ago

I've allowed myself to bump PHP dependency in composer.json and extended test config with 3 major Symfony versions (3.4, 4.4 and 5.0). I am not sure it actually tests against components from specified version. but couldn't find better solution.

Anyways all tests are passing right now. Once again sorry for the delay.

COil commented 4 years ago

Hi @javiereguiluz Any chance to have this merged and a new tag please? 🙂

daum commented 4 years ago

@javiereguiluz Do you have a timeline for the merge on this?

javiereguiluz commented 4 years ago

I'm sorry it took me so long to merge this ... thank you all who contributed to this fix.

COil commented 4 years ago

Thanks Javier, I will check this on a newly created Symfony5 project tonight. See you. :)