EasyCorp / easy-deploy-bundle

The easiest way to deploy your Symfony applications
https://easycorp.io/EasyDeploy
MIT License
473 stars 103 forks source link

More docs on how this actually deploys #2

Open Seldaek opened 7 years ago

Seldaek commented 7 years ago

It's not too clear to me what this does, nor how it achieves zero-downtime deploys, etc. I want to believe you, but without technical details, and for having seen so many people mess this up, I have to remain skeptical :)

javiereguiluz commented 7 years ago

Sure! It's explained a bit in this doc: https://github.com/EasyCorp/easy-deploy-bundle/blob/master/doc/default-deployer.md The default deployment strategy is a copy of Capistrano, Capifony, Deployer PHP, etc. So it uses the same trick based on the symlink.

Seldaek commented 7 years ago

I did read that but even doing the "symlink trick" you have to be careful how you configure nginx for example to avoid potentially breaking requests when switching the symlink. I understand that's not your responsibility/control as a deploy tool, but documenting these things and having best practices clearly explained would probably be valuable as a lot of people are not aware of those issues (and while it doesn't matter much on low traffic sites, it doesn't hurt to do it right). I'm happy to help share config stuff if needed.. been optimizing this quite a bit over the years, only thing I still have in a messy state is my homegrown bash based deploy script. I'm hoping I can replace that with this tool.

javiereguiluz commented 7 years ago

Thanks a lot! I'm not sure if this tool will be useful for you ... but any knowledge (and pain!) that you can share while testing it will be invaluable for us. Thanks!