stage the SmtMap -> FMap renaming

EasyCrypt / easycrypt

EasyCrypt: Computer-Aided Cryptographic Proofs

MIT License

320 stars 49 forks source link

stage the SmtMap -> FMap renaming #607

Closed fdupress closed 2 months ago

fdupress commented 2 months ago

This is to stage the renaming in #605 across a release.

Pre-release: add FMap as an alias for SmtMap.
Post-release: deprecate SmtMap by merging #605.

fdupress commented 2 months ago

@strub Any comments on how I'm going about this?

I keep second-thinking that perhaps it is better to rename SmtMap into FMap and make SmtMap the alias.

strub commented 2 months ago

@strub Any comments on how I'm going about this?

I keep second-thinking that perhaps it is better to rename SmtMap into FMap and make SmtMap the alias.

FMap seems a better name to me, indeed. SmtMap is... well.

fdupress commented 2 months ago

@strub Any comments on how I'm going about this?

I keep second-thinking that perhaps it is better to rename SmtMap into FMap and make SmtMap the alias.

FMap seems a better name to me, indeed. SmtMap is... well.

I was more concerned with the way I'm doing this staging. This is keeping SmtMap as it is and adding an FMap file that require exports it.

But I could move the whole thing to be FMap, and SmtMap requires exports FMap? Probably overthinking.