search

EasyEngine / feature-requests

A repo to track all feature requests on EasyEngine project using issue tracker.
5 stars 2 forks source link

Add php 7.3 support #63

Closed PatelUtkarsh closed 3 years ago

PatelUtkarsh commented 5 years ago

Add support PHP 7.3 as it's officially available.

https://twitter.com/official_php/status/1070753276939960320

This can be optional support like ee3.

michacassola commented 5 years ago

Move to feature-request?

mrrobot47 commented 5 years ago

PHP 7.3.0 support will be added very soon. Once it is added, @rahul286 @PatelUtkarsh @rahulsprajapati what should be the default PHP version when a site is created using EasyEngine?

Currently, EasyEngine creates a site uses PHP 7.2.12 if no specific --php=<version> flag is passed. What should be the default behaviour now that the current stable PHP version is 7.3.0?

  1. Continue creating sites with PHP 7.2.12 by default?
  2. Update to last stable of 7.2 family, i.e., PHP 7.2.13 and use it as default?
  3. Switch to the current stable PHP 7.3.0 as the default PHP version as well as update --php=7.2 to latest 7.2.13?

Note: The supported PHP versions during installations will soon be populated to all the versions listed here under section PHP version update for Site type PHP and WP.

PatelUtkarsh commented 5 years ago

I would prefer point 2. We can use 7.3 as default after few releases. @mrrobot47

rahulsprajapati commented 5 years ago

Yep, keep the default php version to 7.2 and add support of other php7 versions to --php flag. As @PatelUtkarsh said we can update the default after few releases.

gijo-varghese commented 5 years ago

Any updates on this?

kirtangajjar commented 3 years ago

Support for php 7.3 has been added.