EasyEyes / threshold

A PsychoJS-based experiment generator for the measuring various psychometric thresholds, e.g., crowding.
MIT License
3 stars 1 forks source link

[BUG]When running a new experiment table the corpus is not proper #84

Open sravyam28 opened 2 months ago

sravyam28 commented 2 months ago

Describe the bug

Created a new reading experiment but the reading corpus is not looking as expected

To Reproduce

Add the below table to examples folder. Run npm run examples run npm start -- --name=easyeyes_buggy_1 easyeyes_buggy_1.csv

Expected behavior

The reading corpus should be clear

Screenshots

Screenshot from 2024-07-11 10-33-57

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

denispelli commented 2 months ago

Dear sravyam Thanks for the bug reports. Can I share a tip? The best way to share an experiment is to “export” it. Once you’re compiler your experiment, EasyEyes displays an “Export” button on the main compiler page. Pressing that button creates an export.zip file in your Downloads folder. The zip includes the spreadsheet and all other resources required to run the experiment (e.g. fonts and corpuses). The file is called NAME.export.zip, where NAME is your experiment name. If you receive such a file you can open it and use the pieces individually, or you can feed the intact zip to EasyEyes which will compile and run it, without saving the resources to Pavlovia. We recommend to everyone filing bug reports to include the export.zip file, making it easy for a programmer to replicate the bug and work on it. Best Denis

On Jul 11, 2024 at 7:42:29 PM, sravyam28 @.***> wrote:

Describe the bug

Created a new reading experiment but the reading corpus is not looking as expected

To Reproduce

Add the below table to examples folder. Run npm run examples run npm start -- --name=easyeyes_buggy /home/sravyam/Downloads/easyeyes_buggy.csv

Expected behavior

The reading corpus should be clear

Screenshots

Screenshot.from.2024-07-11.10-33-57.png (view on web) https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_EasyEyes_threshold_assets_117389237_69848191-2D4d8e-2D40a0-2Db983-2D994ba3e1d203&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=7X-NKAXavKeKD9gIvst_RX6MqmtP6wERm4LVB5ZkcI4&m=GpsDBqcpdmIHHdtXjgKP9oiH3XDQvmVro-678vNrN_LHFYRw_hjyfDNdoawr7J2u&s=q2yNJuadnv3IsUW1GK_Rx37urOdn9iuvoOu1tvkmvzo&e=

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_EasyEyes_threshold_issues_84&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=7X-NKAXavKeKD9gIvst_RX6MqmtP6wERm4LVB5ZkcI4&m=GpsDBqcpdmIHHdtXjgKP9oiH3XDQvmVro-678vNrN_LHFYRw_hjyfDNdoawr7J2u&s=e6rXS7btSZmSrgF7dsXQVFV51ttJ3uECo27APMXDlfk&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ADKWX63AX3KJNJFRZMP7UTLZL27YLAVCNFSM6AAAAABKXOEAHOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDGNZRHE3DCNA&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=7X-NKAXavKeKD9gIvst_RX6MqmtP6wERm4LVB5ZkcI4&m=GpsDBqcpdmIHHdtXjgKP9oiH3XDQvmVro-678vNrN_LHFYRw_hjyfDNdoawr7J2u&s=zCzmYCQ9JT1PdsQpUHju1kcbhQgDAxlgRWJRGIygd88&e= . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sravyam28 commented 2 months ago

Hi Denis, Thanks for letting me know. Do you think it would be the same if I can zip the compiled experiment folder from examples and attach it here? I work on the experiments directly from threshold repo and not from Pavlovia but if it is the same I can attach it from my repo after compiling it.

denispelli commented 2 months ago

Oh. Yes. Sure. Just include all needed resources with the experiment spreadsheet. They ought to work. However the other day I opened an export zip edited the experiment and rezipped it, expecting it to work but the compiler went haywire. My hunch is that there are multiple zip formats and our compiler is not compatible with the macOS finder’s zipping. It wasn’t a matter of failing to unzip. It “unzipped” and complained about weird resource problems. So it would be a subtle failure. Alas the person who wrote the export/import code just left for greener pastures. So it will be a while before I can put someone on it.  So, yes, let’s try what you suggest but we might need to try several zippers before we find one compatible with the EasyEyes compiler. BestDenis Denis PelliProfessor of Psychology & Neural Science, New York University+1-646-258-7524  @.://psych.nyu.edu/pelli/  | Skype: denispelli| http://denispelli.comSent from my iPhoneOn Jul 11, 2024, at 8:58 PM, sravyam28 @.> wrote: Hi Denis, Thanks for letting me know. Do you think it would be the same if I can zip the compiled experiment folder from examples and attach it here? I work on the experiments directly from threshold repo and not from Pavlovia but if it is the same I can attach it from my repo after compiling it.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

sravyam28 commented 2 months ago

attaching zip file easyeyes_buggy_1.zip

sravyam28 commented 2 months ago

Hi @denispelli I updated a zip file of the build folder, can you please check and let me know. Also the issue is also seen in the readingExperiment in examples so it can be reproduced even without my tables.

sravyam28 commented 1 month ago

Hi @denispelli Thanks for the fix and update. With the latest main branch (on commit d80976493ae2c081f12fa4b32fe2c134a749bc0b) I see the corpus is far up in the screen and some of it could not be seen I think; below is the screenshot of how it looks. Can we know if any param in the table used in this case needs to be changed for correct corpus. easyeyes_buggy_1.csv 453600282_447365671626388_8035444405185950226_n