Closed diveshuttam closed 5 years ago
:+1: I am going to have a look at it soon.
If you need to merge it (for example if it prevents you from working further) you can go on. I can still review it and make any necessary fixes after it has been merged.
Cool! Also you might find it easier to test this after setting and key commands are ready. I am currently working on them will create a pr by tomorrow. Maybe we can address this after I implement them also and save some time.
Thanks, I appreciate it.
Closes #87, Closes #86 , Closes #80 This pr implements the most of the contact commands as well as key commands for initialization.
I have added possible improvements as TODO's, they are mostly something I struggled with either conceptually or because of yad.
@dashohoxha have a look whenever you are free. TODO's required some thinking and discussion so I would probably solve them in another pr.
Note:
contact search
it was difficult to implement the gui. I have launched a gnome-terminal instance instead with the gui command. While testing on the container, you will require to download the same. I am not adding it in docker file as it is a temporary solution. Will improve in another prSince I was taking many features in consideration, I have used commits with proper messages for each unit. It might help you in review.