EasyGnuPG / egpg

Easy GnuPG, shell scripts to make GnuPG more accessible and easier to use. (Migrated to: https://gitlab.com/EasyGnuPG/egpg)
GNU General Public License v3.0
26 stars 5 forks source link

Gui contacts and key generation #90

Closed diveshuttam closed 5 years ago

diveshuttam commented 5 years ago

Closes #87, Closes #86 , Closes #80 This pr implements the most of the contact commands as well as key commands for initialization.

I have added possible improvements as TODO's, they are mostly something I struggled with either conceptually or because of yad.

@dashohoxha have a look whenever you are free. TODO's required some thinking and discussion so I would probably solve them in another pr.

Note:

Since I was taking many features in consideration, I have used commits with proper messages for each unit. It might help you in review.

dashohoxha commented 5 years ago

:+1: I am going to have a look at it soon.

If you need to merge it (for example if it prevents you from working further) you can go on. I can still review it and make any necessary fixes after it has been merged.

diveshuttam commented 5 years ago

Cool! Also you might find it easier to test this after setting and key commands are ready. I am currently working on them will create a pr by tomorrow. Maybe we can address this after I implement them also and save some time.

dashohoxha commented 5 years ago

Thanks, I appreciate it.