search

EasyPost / easypost-csharp

EasyPost Shipping API Client Library for .NET and .NET Framework applications
https://easypost.com/docs/api
MIT License
66 stars 74 forks source link

[Feat]: Add BuyerAddress and ReturnAddress support in EasyPost.Parameters.Order.Create #560

Closed cary-opcenter closed 7 months ago

cary-opcenter commented 7 months ago

Feature Request Is New

Description of the feature

The buyer_address and return_address objects are part of the order object, but cannot currently be added to order parameters using the csharp client library.

I can include the BuyerAddress and ReturnAddress to a shipment parameter, but my tests show that these addresses are replaced or overridden by the ToAddress and FromAddress which is the default behavior when not provided in the order object.

While I am a novice programmer, I've attempted several ways to pass these address objects into an order parameter, but have had no luck. I've attached a screenshot of how I would like to implement a BuyerAddress when building an order, but the compiler has an error: "CS0117: 'Create' does not contain a definition for 'BuyerAddress'". image

As an aside to this feature request, if there is another method to send these address objects with my order object I could use some advice or suggestions. (Thanks in advance) I would be glad to contribute to this issue however I could, let me know what I can do to assist.

HottieHotton commented 7 months ago

Hey @cary-opcenter, this is Braxton Hotton from Support who helped you a few days ago. I had another person ask about this and this is something that our engineers will add along with IsReturn being an allowed parameter in the top level of Orders. I just got confirmation not to long ago that this will be happening.

Our engineering team will be in touch shortly!

Best, Braxton Hotton Technical Support Engineer easypost.com

The Simple Shipping Solution

nwithan8 commented 7 months ago

Hello @cary-opcenter , thanks for reaching out. As Braxton said, BuyerAddress is something we'd have to explicitly add support for in the parameter sets, and unfortunately something that got overlooked. It's in progress in #561 and should be available in the next release.

cary-opcenter commented 7 months ago

Hi @HottieHotton and @nwithan8 Thanks for the quick response! It's very cool to hear that these updates were already in the pipeline, and I am looking forward to the update.

I appreciate the great service you guys provide and the excellent work done by the EasyPost team 🙌

HottieHotton commented 7 months ago

Hey @cary-opcenter, of course! Glad we've been able to assist! I just wanted to follow up that the code is in review now. We've decided NOT to move forward with IsReturn being added to the Order level, as those should be done via the /shipment endpoint. However, BuyerAddress and ReturnAddress will be added once this release is out.

Please let us know if you have any further questions!

Best, Braxton Hotton Technical Support Engineer easypost.com

The Simple Shipping Solution

nwithan8 commented 7 months ago

@cary-opcenter v6.4.0 has just been released and includes the missing parameters that Braxton mentioned above.