EasyPost / easypost-java

EasyPost Shipping API Client Library for Java

https://easypost.com/docs/api

MIT License

54 stars 37 forks source link

Adds OS specific details to the user-agent header #153

Closed jchen293 closed 2 years ago

jchen293 commented 2 years ago

Description

Adds OS-specific details to the user-agent header

Testing

Screen Shot 2022-06-30 at 1 44 55 PM

Pull Request Type

Please select the option(s) that are relevant to this PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Improvement (fixing a typo, updating readme, renaming a variable name, etc)

jchen293 commented 2 years ago

The code looks fine, I would however like an Implementation piece included like we did with Python. What kind of Java are they using.

added

jchen293 commented 2 years ago

So the way that our User-Agent header works is that each new "section" is delimited by a space. The Implementation section has spaces in it. We may want to join each piece of that section with an underscore or something similar so that the sections are consistent. Does that make sense? (this is based on the new pic)

This also applies to other sections as well, we need to add this in other libs or the one(s) that already rolled out.

Justintime50 commented 2 years ago

This also applies to other sections as well, we need to add this in other libs or the one(s) that already rolled out.

Can you supply an example of this happening? I don't believe this is actually the case. In Python, the Implementation will be something like Pypy or CPython and won't have extra spaces in it.

jchen293 commented 2 years ago

This also applies to other sections as well, we need to add this in other libs or the one(s) that already rolled out.

Can you supply an example of this happening? I don't believe this is actually the case. In Python, the Implementation will be something like Pypy or CPython and won't have extra spaces in it.

Ok, in Python this probably will not be an issue, but for the OS name, in my case, it would be Mac OS X, we definitely want to convert spaces to hyphens.

Justintime50 commented 2 years ago

Ok, in Python this probably will not be an issue, but for the OS name, in my case, it would be Mac OS X, we definitely want to convert spaces to hyphens.

Can you show me this? It should be Darwin