EasyPost / easypost-java

EasyPost Shipping API Client Library for Java

https://easypost.com/docs/api

MIT License

54 stars 37 forks source link

move validateWebhook to Utilities file #215

Closed jchen293 closed 1 year ago

jchen293 commented 1 year ago

Description

move validateWebhook() to Utilities file since it does not require an EasyPostClient object and does not belong to Webhook object instance.

Testing

unit tests pass

Pull Request Type

Please select the option(s) that are relevant to this PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement (fixing a typo, updating readme, renaming a variable name, etc)

Justintime50 commented 1 year ago

Not a fan of user-facing utilities like validate webhook or lowest smartrate being in the same file as internal utilities like instanceURL and getEncodedUrl, but that's for another day.

Why don't we move the internal stuff to a new InternalUtil file then? That way we can retain the nice clean Util namespace for user/public facing items and we separate out the internal from it?

Justintime50 commented 1 year ago

Per discussions, we're going to split out utils into util or internalUtil.
We also need to move the validateWebhook, and lowestSmartRate from wherever they are to the util file

jchen293 commented 1 year ago

Forced push to rebase from master branch to solve a few merge conflicts