Closed nwithan8 closed 1 year ago
praise: This is awesome, nice work!
question: before merging, can we re-record one cassette locally to ensure that a fresh HTTP request gets made and comment back on the findings? No need to commit the cassette
Yes, cassettes are recorded and replayed as expected:
Description
Rather than storing a global VCR (requiring EasyVCR to be a production dependency), we now store a global Function that accepts a string and returns an
HttpsUrlConnection
. This function is set by the test suite to use the configured VCR, but this means thatEasyVCR
does not leave the test suite.Should close #265
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.