EasyPost / easypost-java

EasyPost Shipping API Client Library for Java
https://easypost.com/docs/api
MIT License
53 stars 37 forks source link

[chore] Explicitly define "Accept" header for requests #269

Closed nwithan8 closed 1 year ago

nwithan8 commented 1 year ago

Description

Addresses bug in Java 8 which uses a confusing default "Accept" header if not defined: https://bugs.openjdk.org/browse/JDK-8163921

Not a breaking change, but makes our API logs easier to read and consistent with expected behavior.

Testing

Pictures of cassettes below confirm new "Accept" header being included in the request.

Before:

image

After:

image

Cassettes do not need to be re-recorded since we do not enforce matching by headers in our VCR.

Pull Request Type

Please select the option(s) that are relevant to this PR.

Justintime50 commented 1 year ago

This probably isn't needed anymore