EasyPost / easypost-java

EasyPost Shipping API Client Library for Java

https://easypost.com/docs/api

MIT License

53 stars 37 forks source link

Add Java 21 in the CI build #293

Closed jchen293 closed 9 months ago

jchen293 commented 9 months ago

Description

Add java 21 in the CI build Bump lombok to support JDK 21

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement (fixing a typo, updating readme, renaming a variable name, etc)

Justintime50 commented 9 months ago

question: why do we have lombok defined twice in pom.xml? Can we remove one of them and just define it once?

jchen293 commented 9 months ago

question: why do we have lombok defined twice in pom.xml? Can we remove one of them and just define it once?

That one is for error-prone specifically since Lombok will auto-generate the setter/getter methods for you, removing it will cause the build to fail because error-prone will throw errors indicating getter/setter methods are not found.