EasyPost / easypost-python

EasyPost Shipping API Client Library for Python

https://easypost.com/docs/api

MIT License

111 stars 57 forks source link

Cleanup2 #278

Closed Justintime50 closed 1 year ago

Justintime50 commented 1 year ago

Description

Cleans up easypost_object and requestor by removing dead code, fixing style, and moving the requestor logic traditionally setup during import to the init of the client object finishing off thread-safety for this library.

Closes #97

Testing

Updated tests as needed

Pull Request Type

Please select the option(s) that are relevant to this PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Improvement (fixing a typo, updating readme, renaming a variable name, etc)

Justintime50 commented 1 year ago

Not a huge fan of how the API version gets set (would prefer on a per-request basis rather than instance-wide, to allow for "beta" when needed without splitting strings), but won't block on it.

It already works that way, if you pass the beta=True param, we replace the version with beta 🙂 Unless I'm misunderstanding?