Feature Request - "Quick Edit" on Event Editor

EasyRPG / Editor

Game editor similar to RPG Maker

https://easyrpg.org/editor/

GNU General Public License v3.0

350 stars 58 forks source link

Feature Request - "Quick Edit" on Event Editor #179

Open jetrotal opened 3 years ago

jetrotal commented 3 years ago

The workflow would work like this:

User Opens Event Editor
Instead of hitting ENTER to add an Event, the User hits CTRL + ENTER.
A small Text-Box appears after the @> Icon.
As the User types, a floating list of matching events commands appears on a Combo-Box underneath the Text-Box.
The User hits tab to edit command's params.
some params has an ... icon in order to open the dialogs that edits facesets, charasets or variables.
After setting everything up, the User corfirms by pressing enter one last time.

It would look like this incomplete mockup i made in JS: https://codepen.io/jetrotau/pen/oNWaOdj

Ghabry commented 3 years ago

These Inline Event editing makes perfect sense.

I also consider editing events in the original editor awkward and slow.

This mockup for the event editor is e.g. quite nice http://finalbossblues.com/des/rpgmacker/rmui.html

jetrotal commented 3 years ago

Yeah, ENTER and SPACE would call the default Command Menu, CTRL + ENTER and CONTROL + SPACE would call the Quick Edit/Quick Create Menu Behavior i'm suggesting...

I feel like something like this could also speed up the development of Commands, since you could leave the UI for later updates.

The concept is inspired by both VSCode's Auto complete and an After Effects plugin called "Quick Menu": 52618551-d46f7080-2ea7-11e9-9de5-1caa553ff398 qm_2 0_cmds

You can find more about how to implement this by looking for "Fuzzy Search" on your favorite coding language.

The mockup you posted looks amazing, but the event tab feels a little overwhelming . Too much stuff to pay attention. Maybe graying out some stuff that isn't on focus could help.

Ghabry commented 2 years ago

There are still some road blocks but I'm close to get a first draft for inline editing of event commands working. At least the simple ones.

And yes it will be qml based because doing this with QWidgets is really hard

The idea is a bit inspired by scratch: https://projects.raspberrypi.org/en/projects/getting-started-scratch

Ghabry commented 2 years ago

Here a very basic POC:

Screenshot_20211202_150410

And I must say: Wow. The QtQuick controls are beyond terrible. You cannot: Select text in a text field with the mouse and there is also no context menu. WTF is this shit???

@jetrotal mentioned some binding of QWidgets to QML. Can you link this here? The normal Quick Controls are too embarassing.

jetrotal commented 2 years ago

There you go https://github.com/KDAB/DeclarativeWidgets https://www.kdab.com/declarative-widgets/

Random question, Do you think i can set up my own qml playground like this: https://github.com/patrickelectric/qmlonline and incorporate on it some libraries that are important to the project?

Like the declarative widgets

I wish I could help with these stuff, and something like qmlonline could help me testing on the go

Ghabry commented 2 years ago

Give me a week or two. Then will see if I can get any WASM-related stuff working.

Besides DeclarativeWidgets I was also able now to get Kirigami working (at least Linux). This is entirely QML based and even works on systems like Android so getting it into a web interface for playing around should also work...

jetrotal commented 2 years ago

Here's also a working mockup to an Event Selector tab: https://codepen.io/jetrotau/pen/rNGVJqZ

It's very similar to the one used on RPG Maker Unite, but it was made 5 months prior to it 😬