search

EasyRPG / Editor

Game editor similar to RPG Maker
https://easyrpg.org/editor/
GNU General Public License v3.0
336 stars 59 forks source link

Command to add links outside the game #213

Open Br4ssman opened 1 year ago

Br4ssman commented 1 year ago

I've been thinking about it for discussion, I don't know if it's too dangerous or if it might be interesting.

carstene1ns commented 1 year ago

Unfortunately this will not work in a cross-platform way.

fdelapena commented 1 year ago

For Player on SDL ports (>= 2.0.14) there is SDL_OpenURL(): https://wiki.libsdl.org/SDL_OpenURL For Qt for the editor there is QDesktopServices::openUrl(): https://doc.qt.io/qt/qdesktopservices.html

Mimigris commented 1 year ago

I've been thinking about it for discussion, I don't know if it's too dangerous or if it might be interesting.

Not sure if you wanted to receive feedback for this but I'm gonna give mine anyways since it may be interesting I guess.

While it can be interesting in some cases to be able to link the user to a specific site, you need to also know how the community would use it, both in a good and in a bad situation since we are talking about an indie community making games. I'm pretty sure that some developers would try to exploit this maliciously, for example by sending the user to malicious or inappropriate websites, or by making a loop asking the player to open a page endlessly to make your device struggle. One way to avoid such exploits would probably be to make the command work as a wait for key input to avoid the latter, but it would limit the command and would not solve the first issue. At this point, I think that it would be better to just put a link in the readme or show it in-game and ask the user to type it to avoid issues, so I'm not really for having such a feature when releasing a game.

If there is a plan to have this feature though, I don't think that having it on a limited number of platforms is really an issue as long as the main platforms are supported. Having links in the Editor itself should not be an issue since its content should always be the same and should not be exploitable so there is no issue here.