Captain Novolin RPG (2k3) - Crashes while trying to load panorama during intro

[NovemberJoy]

Name of the game: Captain Novolin RPG

Download link: Here

Player platform: Windows 10 Home 1709 64-bit

Attach files (as a .zip archive or link them)

• easyrpg_log.txt
  • Crash dump

Describe the issue in detail and how to reproduce it: Start a new game and select either difficulty setting. During the intro, after the first couple of lines past the difficulty selection, it will crash before displaying a panorama every time.

[fmatthew5876]

This is caused by Change Parallax Back commands which set auto scrolling. Processing one of these causes a divide by 0 exception when updating the parallax BG.

Likely a 6.0 regression caused by moving Parallax update after the foreground interpreter but haven't verified.

Will fix.

[fmatthew5876]

Test Cases 1 - Panorama commands

Create map with 100x100 tiles

1. EV01 autostart

   Change Panorama: Horiz Loop (+1) Vert Loop (+1)
   Loop:
   OpenSaveMenu

Save	pan_x	pan_ y
1	20478	15358
2	20476	15356

2. Change EV01 to parallel

Save	pan_x	pan_ y
1	0	0
2	20478	15358
3	20476	15356

3. Change EV01 to parallel and add Wait 0.0s as the first command

Save	pan_x	pan_ y
1	20478	15358
2	20476	15356

Conclusion

• Requests to load panoramas are processed at the end of the frame.
• Requests to load panoramas during pre-update are deferred until the end of the first frame.
• Uses panning coordinates based on map size?? :exclamation:

[fmatthew5876]

Test Cases 2 - Preset panoramas

Setup the Map with cosmos panorama. Horiz scroll, auto, +1, vert scroll, auto, +1

1. EV01 parallel

Loop:
  OpenSaveMenu

Save	pan_x	pan_y
1	512	512
2	510	510

Conclusion

• Uses panning coordinates of the image size

[Ghabry]

This crash affected 8 users on Android btw. :+1: