EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
991 stars 186 forks source link

List of custom EasyRPG terms #2362

Closed fmatthew5876 closed 3 years ago

fmatthew5876 commented 4 years ago

This issue is to create a list of all the hard coded strings in RPG_RT that we would like to add as customizable Terms as an easyrpg extension. The rule can follow SaveActor::name, in that the string defaults to \x1 which means use the RPG_RT compatible default value.

We could also extend the RPG_RT defaults to use "advocate" or "2k3e" translations, depending on the engine version.

Menu Scene (#2473)

Battle Scene (#2502)

Ghabry commented 4 years ago

The 2k3 battle notification for skill (currently is the skill name) should be also customizable (with placeholder support as in 2k)

Tayruu commented 4 years ago

I've edited things like these myself in my RPG_RT, so the ability to set them somehow without compiling my own Player would be neat. (Though I have some functions I'll need to custom compile anyway.)

Just missing the "-----/-----" of max EXP.

Ghabry commented 4 years ago

This --------/------- vs EXP/-------- could be also a configuration. But more a flag than a term.


Or maybe we should just add the "Scene Push" event command I suggested, reimplement the entire Menu scene in RPG Maker Event script and then you can alter stuff by modifying event code ;))).

ghost commented 3 years ago

The "Confirm" and "Redo" commands in the party order scene are hard coded as well.

Ghabry commented 3 years ago

@rueter37 I just saw this commit in liblcf: https://github.com/rueter37/liblcf/commit/cf01c364b07c974aa0fb3a0a13cbd69345202386 Can you PR this commit? Looks like a good start for this feature.

ghost commented 3 years ago

@Ghabry I have opened a PR with the commit you mentioned now in liblcf.

ghost commented 3 years ago

I think the ------/------ vs EXP/------ on the last level should be a user preference. But my proposal here requires #2035 to be merged in.

ghost commented 3 years ago

Don't get fooled by the text which says that my PR #2473 will close this issue. It is only a partial fix.

Ghabry commented 3 years ago

You must reword it to prevent an autoclose. We usually use e.g. Related: #1234

ghost commented 3 years ago

Thanks for the pointer how to disable the autoclose! :+1:

ghost commented 3 years ago

Since #2399 is merged in now we can take on the battle scene terms now. You can check out this liblcf and player branch which has got everything needed for battle scene terms and customizable battle notifications for skills in RPG Maker 2003 battles.

Ghabry commented 3 years ago

I see that you also added Placeholder support?

ghost commented 3 years ago

Yes, to make the battle notifications for skills more useful (see your comment).

ghost commented 3 years ago

Added a liblcf PR and Player PR now which should implement the remaining features to close this issue.