EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
989 stars 185 forks source link

[Feature request] Make sure the game load files of the translation #2829

Open Mimigris opened 2 years ago

Mimigris commented 2 years ago

When a translation is loaded, the translated files from "System", "System 2" and all of the "RPG .po" files should be entirely loaded to make sure the translation work correctly. Actually it does not exactly do that, so for example elements from "RPG_RT.ldb.common.po" are not all translated as intended. This also happens with maps.po files when loading a save.

Tested with Uneven Dream on Windows with the latest build of EasyRPG Player; the computer's menu is not completely translated sometimes even if it's entirely translated. The file seems to at least be partially loaded since the texts related to effects obtention seems to appear as translated when seen in-game. It seems to be correctly loaded after doing: "New Game -> Exit to Title Screen" or "Continue -> Exit to Title Screen".

Example picture when the file is not correctly loaded: image

And when it's correctly loaded: image

Ghabry commented 2 years ago

When you load a save that has a different language the strings won't be replaced.

The reason is simple: Event code is copied into the savegame and the origin of the event code (original Event ID and Map) is lost.

So it is impossible to retranslate this because the context is missing.

This fixes itself when you change the map once.

Mimigris commented 2 years ago

When you load a save that has a different language the strings won't be replaced.

The reason is simple: Event code is copied into the savegame and the origin of the event code (original Event ID and Map) is lost.

So it is impossible to retranslate this because the context is missing.

This fixes itself when you change the map once.

Was expecting something like that for maps, but the example I've given is from the RPG_RT.ldb.common.po, and due to not being a map.po where it's refreshed, the untranslated lines are only refreshed by reloading the game. Also System graphic can't be directly loaded on the translation ? I have this issue when playing a translation for Yume Nikki, and the Count graphic is as such not translated until manually changing System in-game.

Ghabry commented 2 years ago

The same issue I describe also happens for Parallel Process common events but it is worse: They are only suspended and never reloaded, so there is no retranslation happening.

Fixing this will be harder. We could e.g. store the language in the savegame and then reload all events when the languages mismatch.

System graphic translations should work.