EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
1.01k stars 192 forks source link

Support SDL3 (when it is out) #2865

Open Ghabry opened 1 year ago

Ghabry commented 1 year ago

As the title says. Library has new name etc.

Ghabry commented 1 year ago

Made a quick build test and this throws hundreds of errors due to renamed API everywhere. They are really doing a huge cleanup.

There is a semantic patching script here: https://github.com/libsdl-org/SDL/blob/main/build-scripts/SDL_migration.cocci

This solves some of the errors but by far not all of them. Also does not add new required checks for return values etc.

Moving forward is likely the best to wait for first SDL3 release candidate so the API stabilizes and then create a sdl3_ui.cpp/h based on sdl2_ui.cpp/.h.

Depending on how hard it is new features can then be added to SDL3 only or backported to SDL2. Shouldn't be as hard as keeping SDL1 alive *g*

Ghabry commented 1 year ago

Patch to add SDL3 support: https://github.com/Ghabry/easyrpg-player/commit/c41ad5593a0748e90bfa3f8c40dfa18714f6d055

Not suitable for merge until SDL3 releases for the first time.

fdelapena commented 11 months ago

Relevant comment for tracking: https://github.com/EasyRPG/Player/issues/1036#issuecomment-1818208561

Ghabry commented 8 months ago

Updated my sdl3 branch to build against latest SDL3 state.

Remaining issues: