EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
991 stars 185 forks source link

Steamed Hams: Archive fails to open because of duplicated file #3094

Closed Mimigris closed 10 months ago

Mimigris commented 1 year ago

Name of the game:

Steamed Hams (...but it's RPG Maker 2003!).

Player platform:

Android, 64 bits continuous build.

Describe the issue in detail and how to reproduce it:

When trying to load a game that is stored in a folder with a conflicting name, like with Steamed Hams 2003, and that EasyRPG will not accept to launch it without unzipping it, trying to load it on the Android version will cause the app to exit, and reopening the app without resetting will bring the "this folder is not valid" message. Adding a warning when trying to open the game when it cannot be opened directly on the Android game browser would be a good idea for cases like this.

Ghabry commented 1 year ago

Uhm. The bigger question is why it is crashing 😅

Mimigris commented 1 year ago

Uhm. The bigger question is why it is crashing 😅

If you tried to open it without unzipping on the Windows version, those are the issues that would be displayed, so it's likely related to this. image

Ghabry commented 1 year ago

Oooh. It could be that a file can be multiple times in the zip archive (because files were replaced later) like we noticed with RTP assets in the lzh file .

And the rule is probably "last file wins"

Ghabry commented 11 months ago

Checked this again while finished the LZH support:

The archive contains a file "Steamed Hams 2003" which is the same as a folder name. No idea how this can happen (append to zip?) but the strategy "last file wins" also helps against this.