Detect the engine version for "Ahriman's Prophecy" correctly

EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter

https://easyrpg.org/player/

GNU General Public License v3.0

965 stars 183 forks source link

Detect the engine version for "Ahriman's Prophecy" correctly #3095

Closed Ghabry closed 9 months ago

Ghabry commented 9 months ago

It is RPG Maker 2003 1.0.8.0 but their exe file lacks a VERSIONINFO.

The code segment size is checked instead to detect the version correctly.

Segment size taken from this Makerpendium page: https://www.makerpendium.de/index.php/RPG_RT.exe

Finally a simple commit to review ;)

Reported by samuel in the forum https://community.easyrpg.org/t/ahrimans-prophecy-battle-menu-problem-android/1332 Thanks!

Ghabry commented 9 months ago

To have this documented:

UPX compressing preserves the VERSIONINFO and the LOGO resources. However the CODE segment is gone.

This means a UPX compressed RPG Maker 2003 < 1.02 game will be incorrectly detected as RPG Maker 2000 VALUE!

All other UPX'ed RPG Maker 2003 games (except with hacked exe that deleted the VERSIONINFO :P) will be correctly detected, as "code size" is only used for the VALUE! vs. ancient 2k3 game check.