EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
965 stars 183 forks source link

Update key descwiptions #3107

Closed MikuChan03 closed 8 months ago

MikuChan03 commented 9 months ago

Hi~~

Watakushi (said when sewious), doesn't want to be a bothew, but watakushi believes that the wwong key descwiptions could make usews dizzy.

screenshot_1

So hewe's a tiny PW that changes what I said in #3104. While at it, we also wemove the x3 and x10 pawt in the fast fowward descwiptions, because that's configuwable now

jetrotal commented 9 months ago

Heyo!

Maybe renaming FF buttons to "Fast Foward A" and "Fast Foward B" could help, since nowdays it's possible to make the second slower than the first.

Not necessary, but I wonder if it would be possible to concat the speed value from the FF variables to help showing what they do?

Thanks again!

MikuChan03 commented 9 months ago

@jetrotal sure, will do ^.^ Though if we weally wanted to go all out, we would make the cweation of these speed modifiews and the keybindings of them dynamic, meaning the usew could have like 10 diffewent speed modifiews?

jetrotal commented 9 months ago

hm... unlimited speed modifiers? I wonder...

Though, there are games that uses a lot of buttons already, and we plan to reserve more shortcuts to when we add support to multiplayer features from https://github.com/monokotech/EasyRPG-Multiplayer-Native

Maybe 2 is already a good amount 🤔

Mimigris commented 9 months ago

If you want my opinion, 2 buttons to edit the speed is likely good enough for now, it could still be changed later in any case if there's a request. 👍

MikuChan03 commented 9 months ago

KK,

watashi did all that good stuff! Meaning watashi changed not only the usew facing descwiptions of fast fowwawd, but also the souwce code. Only the actual Enums wewe too scawy fow watashi, because they awe being used in platfowms as well.

screenshot_0

Made it so that the descwiption is dynamically updated too:

screenshot_1

Evewything is happening so much 🤪

jetrotal commented 9 months ago

Thanks for the help, very sugoi and very kakkoii.

Ghabry commented 9 months ago

Jenkins: test this please

MikuChan03 commented 9 months ago

Sowwy, fowgot to exchange a vawiable name in platfowms. Will do so wight away.

MikuChan03 commented 9 months ago

Jenkins: test this please

Ghabry commented 9 months ago

Jenkins: test this please

Sowwy, only admins can do this

nbittich commented 9 months ago

you should have said pweease jenukinsu san

Ghabry commented 8 months ago

Imo this looks fine. I just want to do a chance on the Android Java Ui side so it reads/writes the value directly through the INI like we already do for some other settings.

Will do this next week, I don't have all the Android dev env crap setup on this system.

Ghabry commented 8 months ago

Currently not motivated to do the Android stuff. Merging this for now and fixing that minor problem later

TruncatedDinoSour commented 5 months ago

a

DeveloLongScript commented 3 months ago

github in a nutshell

trolls