EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
965 stars 183 forks source link

RTP: assets called outside of the intended situation are filename sensitive #3172

Open Mimigris opened 6 months ago

Mimigris commented 6 months ago

Name of the game:

Yume 2kki.

Player platform:

Windows, 64 bits continuous build, and tested as well on the Android version.

Describe the issue in detail and how to reproduce it:

For this issue, you need to have an RTP installed but not the 2k Japanese one. Go on the computer in Urotsuki's Room and select the save icon (this should open the save menu). From there, either save or cancel, and this warning should be displayed: screenshot_213 System/システム is an asset from the RTP that is called here, and it seems that the Player is unable to load it if there is no RTP asset with the proper filename mentioned if called outside of the intended situation. This means that this asset will not be able to be used in said condition if the Japanese RTP is not installed and that you try to use an English RTP.

_In short on why this System is called as a png here: it was likely done to cause a crash on the RPGRT if the RTP of the user is incorrectly or not installed when loading a save, forcing one to make sure that it is properly installed, and it is displayed as a picture since they didn't wanted to deal with editing the System of the player mid-game. Outside of this warning this has no consequences on the game itself on the Player.

Another example done on my side, with just the official 2k English RTP installed properly and not the one from Don Miguel. Loading Panorama/Morning1 (asset from the Don Miguel RTP) as a panorama will work fine but will be considered as missing as a picture, while Panorama/Sky1 (asset from the official 2k English RTP) will work fine both as a panorama and a picture.

Panorama/Morning1, picture: screenshot_1

Panorama/Morning1, panorama: screenshot_2

Panorama/Sky1, picture + panorama: screenshot_3