search

EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
965 stars 183 forks source link

BGM of main title does not change when loading game with Maniacs 200128 #3176

Closed Br4ssman closed 3 months ago

Br4ssman commented 6 months ago

The game incorporates a custom save/load system with this version of Maniacs.

The process to test this is to get to the title screen, load game and note that the music is set from the map itself, this problem is not remedied until you change area, there is a fade out music and then starts the song of the new area.

I send it to @Ghabry privately as it is a Steam game for spring 2024.

Thank you very much.

Mimigris commented 6 months ago

Seems similar to #3029 that was fixed in the continuous build months ago, just to be sure, have you checked if you were able to reproduce it on the continuous build?

Br4ssman commented 6 months ago

I will provide some more information: I have tested the continuous build, the result is the same, I will explain.

This is the song configured in this map and it sounds like this after passing the intro (new game): https://github.com/EasyRPG/Player/assets/18174790/054d0425-1a58-4acf-8d0f-fc37a7d555c4

This is how it is configured: bgm_conf

If I proceed to resume a game and load normally, the main menu music continues to play: https://github.com/EasyRPG/Player/assets/18174790/01c2212f-5ae3-40f3-b963-15a94f5bc93b

Here is a partial sample of the customised loading screen: custom_loadgame

Br4ssman commented 5 months ago

I add more missing details:

The title screen acts from a map (custom title menu), not the default of RPGM. On the other hand, I'm trying to test if it has a solution from the Maker itself (playing BGM: OFF before loading), so far without success.

There is also no change if the music is configured from the map properties or if it is played from a specific event, so far the options are exhausted.

EDIT: There seems to be a way to fix it FROM RM: common event, Player variable by Map ID and if it matches the music plays.

EDIT 2: It's important to note, that the above fix works as long as the tune set in the map where the game was saved is OFF, even if the common event does its fix, as long as you set a tune other than OFF, the above error returns.

Ghabry commented 3 months ago

@Br4ssman Sorry I'm not sure if I missed it but I cannot find the file you sent me. Can you send it me again?

Ghabry commented 3 months ago

As @Mimigris already stated this was caused by an outdated version of the Player.

Though while testing the game I found a crash due to an incorrect value for a string var https://github.com/EasyRPG/Player/pull/3195/commits/2259b561319befdbb58ab828e99358bbddb782c6

I added this to #3195 :)