EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
989 stars 185 forks source link

Maniac Patch : Fix String Vars with ShowPicture #3182

Closed ToolMan2k closed 6 months ago

ToolMan2k commented 8 months ago

Added the following:

Fixed the following:

Before: 😿 EasyRPG-Failure

After: 😺 EasyRPG-Winners

jetrotal commented 8 months ago

Thanks!

String Vars is a very recent implementation, I wonder if more commands can break when using it.

ToolMan2k commented 8 months ago

Well as you say that. I managed to misplace a "]" character. Fixed it, now it works!

jetrotal commented 8 months ago

@ToolMan2k thx again!

One suggestion: image

Squashing commits like "fixing typos" or "remove debug/comments" always help shortening and maintaning the list of commits

ToolMan2k commented 8 months ago

Squashing commits like "fixing typos" or "remove debug/comments" always help shortening and maintaning the list of commits

Will do!

Ghabry commented 6 months ago

I fixed a bug and moved the commits into you other PR. thanks!