EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
966 stars 183 forks source link

ttyp0 changes (remove Thai and Hebrew), generator fix #3240

Closed rohkea closed 1 day ago

rohkea commented 2 weeks ago

This PR does the following changes:

I'm not sure about the F change. The previous version looked better in running text (but worse in menus), the new version looks better in menus (but worse in running text). Here's before and after:

Before: F in the menu is to the right of all the other letters, but Fi and Fo combinations look better

After: F in the menu is aligned with other letters, but Fi has too much space between letters

Ghabry commented 2 weeks ago

Thanks for the fixes. Imo the new F looks worse (as running text is more common than menus). Maybe shift the E instead one pixel to the right?

rohkea commented 2 weeks ago

Here is version with E shifted to the right: screenshot-move-both-e-and-f

And here are some examples of the running text.

Original: fairy-orig

F shifted to the left: fairy-f-shifted

E shifted to the right: fairy-e-shifted

Ghabry commented 2 weeks ago

Okay this triggers now all that want the D and the E | at the same location.

And we cannot move all upper letters by one to the right, this will look bad in other situations.

This doesn't look solvable without redoing the font... So lets just undo this part.

rohkea commented 2 weeks ago

I've removed the change of the F letter, reverted the original version.

rohkea commented 1 week ago

I've checked, the PR doesn't change Shinonome (the case when Ruby version influences the final file, because of encoding issue), so it can be merged (I hope)

rohkea commented 1 week ago

Renamed .bin into .bit, thanks for noticing!