search

EasyRPG / Player

RPG Maker 2000/2003 and EasyRPG games interpreter
https://easyrpg.org/player/
GNU General Public License v3.0
965 stars 183 forks source link

Idea for the Android port #575

Closed BlisterB closed 7 years ago

BlisterB commented 8 years ago

Hi guys !

I open this issue to centralize suggestions about how improve the Android port, don't hesitate to give me job :) !

Idea :

Ghabry commented 8 years ago

Do what you want. I don't maintain the Android port :dancer:

fdelapena commented 8 years ago

Interesting article about the API target concept: http://simonvt.net/2012/02/07/what-api-level-should-i-target/

Ghabry commented 8 years ago

A user suggested an option to disable the music because he prefers listening to his own ;). Completely disabling is currently possible via "--disable-audio", better control is suggested in #794

BlisterB commented 8 years ago

I was thinking about this and I suggested it to one of the french invaders. --disable-audio is cool, but it works just at the game launch, right ?

They will try to find a way to modulate the app volume.

Ghabry commented 8 years ago

I don't want an Android only solution for modulating app volume and there is no obvious reason why you should use platform specific code for this. This is also useful for other ports (a friend already complained about the loudness of emscripten)

BlisterB commented 8 years ago

Okay, but the user should be able to modulate the volume in app during a game. No ?

So if I follow you, we should be able from the android app to call a native function (which act as a callback design pattern on the C++ code?) during a game. If we have such a function, it would be easy to implement the thing from the Android code (a call to changeVolume(value) in onResume( ) and onRestart()).

BlisterB commented 8 years ago

Of course, we could assume that the user has to go in the settings to modify the volume (so stop the game). It makes sense in the actual form of the app, but we won't be able to add a features such as "modify the volume" in the menu of EasyRpgActivityPlayer. But honestly your solution is fine (it's not a big thing to stop the game), but it would be nice to use a flag with a value, such as --volume 90. To use a spinbar in the settings (I assume some people like me want to hear a podcast, but also have a little volume of the game).

(Of course, we can just have a checkbox to enable/disable volume in Setting, it will be easier to implement - Captain Bash, if your reading that).

Ghabry commented 8 years ago

See https://github.com/EasyRPG/Player/issues/794#issuecomment-197792437

So a "Open Settings" option in the EasyRpgPlayerActivity to trigger Scene_Options (which doesn't exist yet) is good enough

BachirAmiri commented 8 years ago

I'll try adding the volume checkbox :)

(btw it's kael from the forum, nickname already taken on git )

BlisterB commented 8 years ago

@Souigetsu Thanks Captain, this will be cool waiting the feature of Ghabry.

@Ghabry Are you talking of a doing a menu similar to your gamebrowser ? This will be cool. Maybe a little confusing with the Android GUI but it's not a big thing, we will fing a good compromise when Scene_Options will be ready :).

sushi24 commented 8 years ago

I'll try to help captain on this duty! ;)

BlisterB commented 8 years ago

Don't worry it's pretty simple. If you have time for another feature, you can do the "Force orientation Auto/Portrait/Landscape", it will be pretty the same as for the Volume features : an option in PreferencesActivity, some condition to add in EasyRpgActivity.

Ghabry commented 8 years ago

Edit the layout in game would be a good improvement but, Android lolilol => will probably kill the game session while the user edit the layout in another activity x).

Actually I have this problem with "FB Lite" (FB App replacement): Attaching an image is impossible because it opens an indent e.g. file browser or camera. After selecting an image it returns, and the app restarts, because the system doesn't have enough RAM m(

Ghabry commented 8 years ago

@BlisterBoy another useful feature would be a language select in the settings. If somebody hates our translation ;) or to force english.... most of the time app translations are bad or wrong

Ghabry commented 7 years ago

@BlisterB can we close this meta-issue?

BlisterB commented 7 years ago

Of course :)

Le 4 oct. 2016 5:59 PM, "Ghabry" notifications@github.com a écrit :

@BlisterB https://github.com/BlisterB can we close this meta-issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EasyRPG/Player/issues/575#issuecomment-251432012, or mute the thread https://github.com/notifications/unsubscribe-auth/ACRuE0YwhQ4rXZdymQL3gUXNL5U18nsYks5qwnf1gaJpZM4F47bB .