Closed Mimigris closed 1 week ago
Sorry I forgot about this PR. Thanks for this contribution. Imo this is fine even if it's incomplete.
The only minor thing I dislike is this full width black bar that appears when displaying the text because is is less high than the text. Maybe completely remove it so only the text with box is shown?
The only minor thing I dislike is this full width black bar that appears when displaying the text because is is less high than the text. Maybe completely remove it so only the text with box is shown?
This issue is completely intended: the weird black background doesn't appear with the Maniac patch, so it was made like that to show this difference. Luckily, it seems that on my side this issue is fixed when testing with the pr3168 of the Player, so this may already be good. Let me know if you want me to edit it in any case.
This pull request adds a testgame for the Maniac patch. This test suite is not complete at all (missing a lot of tests), but I figured out that completing it before making a pull request wouldn't be really possible since I don't know everything from the patch and that it would take a lot of time, so I will release what I have done for now. I've tried to add explanations alongside some of the commands used for the tests, explaining the specificities of each command and if they are saved or not, so let me know if there's more to add for this part.
Tests done:
Not done: